Update tokens from Figma: AS theme - fare-economy-default#478
Open
github-actions[bot] wants to merge 1 commit into
Open
Update tokens from Figma: AS theme - fare-economy-default#478github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates design token values for Alaska and Atmos light themes based on the latest Figma exports, including a primary blue color change and regenerated token export JSON and bundled JS token files. Flow diagram for updated Figma design tokens pipelineflowchart LR
FigmaFile_l1QtGlJ05qJZ1ug9D2TnpY["Figma file l1QtGlJ05qJZ1ug9D2TnpY"]
Alaska_FigmaJSON["Alaska_theme.Light.json (figmaExports)"]
Atmos_FigmaJSON["Atmos_theme.Light.json (figmaExports)"]
Alaska_JSObject["JSObject--allTokens--alaska.js"]
Atmos_JSObject["JSObject--allTokens--atmos.js"]
WebAppThemes["Web app Alaska/Atmos light themes"]
FigmaFile_l1QtGlJ05qJZ1ug9D2TnpY --> Alaska_FigmaJSON
FigmaFile_l1QtGlJ05qJZ1ug9D2TnpY --> Atmos_FigmaJSON
Alaska_FigmaJSON --> Alaska_JSObject
Atmos_FigmaJSON --> Atmos_JSObject
Alaska_JSObject --> WebAppThemes
Atmos_JSObject --> WebAppThemes
style Alaska_JSObject fill:#0074ca,stroke:#0074ca
style Atmos_JSObject fill:#0074ca,stroke:#0074ca
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If
dist/web/JSObject--allTokens--*.jsare build artifacts, consider updating only the source token definition files and relying on the build pipeline to regeneratedistto avoid manual edits and potential divergence.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If `dist/web/JSObject--allTokens--*.js` are build artifacts, consider updating only the source token definition files and relying on the build pipeline to regenerate `dist` to avoid manual edits and potential divergence.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tokens from Figma from file: https://www.figma.com/file/l1QtGlJ05qJZ1ug9D2TnpY
Summary by Sourcery
Enhancements: